spiffaz opened a new issue, #8749:
URL: https://github.com/apache/incubator-devlake/issues/8749

   ## Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues) and found no 
similar issues.
   
   ## What happened
   
   In `backend/plugins/azuredevops_go/api/blueprint_v200.go`, the 
`makeScopeV200` function has two issues:
   
   1. It does not default `scopeConfig.Entities` to `plugin.DOMAIN_TYPES` when 
entities are empty. When a blueprint is created without specifying entities 
(common in the UI), no scopes are generated and `project_mapping` ends up with 
no rows.
   
   2. The repo scope condition checks for `DOMAIN_TYPE_CODE_REVIEW` and 
`DOMAIN_TYPE_CODE` but not `DOMAIN_TYPE_CROSS`. This means that when only 
`CROSS` is selected, the repo scope is missing from `project_mapping`, which 
breaks DORA metrics that depend on the cross-domain join.
   
   These are the same bugs that were fixed for GitLab in #8743 (which fixed 
#8742).
   
   ## What do you expect to happen
   
   1. When `scopeConfig.Entities` is empty, it should default to 
`plugin.DOMAIN_TYPES` so that all domain scopes are created in 
`project_mapping`.
   2. The repo scope condition should also check for `DOMAIN_TYPE_CROSS`, 
consistent with GitLab and Bitbucket.
   
   ## How to reproduce
   
   1. Create an Azure DevOps connection and configure a blueprint without 
specifying entities (leave entities empty)
   2. Run the blueprint
   3. Check the `project_mapping` table - no rows are created for this scope
   
   Or:
   
   1. Configure an Azure DevOps blueprint with only `CROSS` entity
   2. Run the blueprint
   3. Check `project_mapping` - the repo scope is missing
   
   ## Anything else
   
   Follow-up from #8742 / #8743. The fix applies the same pattern used in 
GitLab.
   
   ## Version
   
   Latest main branch
   
   ## Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to