Hello,

Martin Ritchie wrote:
It would be great of some of you with existing mina applications could
test this new SocketIOProcessor and see if there is difference in
performance.

I tried to test your code, but DIRMINA-290 introduced API changes and your SocketIOProcessor does not compile against Mina-HEAD.
Some comments from a cursory glance at the code:

- the simultaneous use of J.U.C. and backport-util-concurrent seems like a typo (i do that sort of thing all the time with the "organize imports" feature of Eclipse).

- logging should probably be done trough SLF4J and not Log4j.

- can you please tell us how does this "Multi threaded SocketIOProcessor" relates to the "ReadWriteThreadModel" that Robert Greig (also from the QPid project?) introduced some time ago?


Regards,
Luis Neves

Reply via email to