David Jencks wrote:
I have 2 complaints about the schema-bootstrap and schema-extra modules...

1. Many of the source java files that are checked in claim that they are automatically generated. IMO these should either be actually generated as part of the build or their javadoc should clearly state that they are not generated or say that they were once generated and why they aren't generated as part of the build.

Ok the schema generator plugin that generates these schema producers does not overwrite files that it sees in the src/main/java area. It only generates producers into the target/generated-sources directory if the same .java file does not exists in src/main/java.

Now originally we generated empty producers for some schemas then we customized them and moved them to src/main/java.

Hence the bad javadocs.  Feel free to change em if you like.

2. These two modules have the same package name. This is generally a really bad idea and can lead to lots of classloader problems... some of which I recently ran into, such as the protected constructors in public inner classes becoming inaccessible from the other jar when the jars are loaded in different classloaders.

I could fix (2) but not (1) unless someone tells me what the answer is :-)


Hmmm I need to look at this email again later. For now I need to run. Let me get back to you.

Regards,
Alex
begin:vcard
fn:Alex Karasulu
n:Karasulu;Alex
org:Apache Software Foundation;Apache Directory
adr:;;1005 N. Marsh Wind Way;Ponte Vedra ;FL;32082;USA
email;internet:[EMAIL PROTECTED]
title:Member, V.P.
tel;work:(904) 791-2766
tel;fax:(904) 808-4789
tel;home:(904) 808-4789
tel;cell:(904) 315-4901
note;quoted-printable:AIM: alexokarasulu=0D=0A=
	MSN: [EMAIL PROTECTED]
	Yahoo!: alexkarasulu=0D=0A=
	IRC: aok=0D=0A=
	PGP ID: 1024D/4E1370F8 BBCC E8D8 8756 2D51 C3D4 014A 3662 F96F 4E13 70F8=0D=0A=
	
x-mozilla-html:FALSE
url:http://people.apache.org/~akarasulu
version:2.1
end:vcard

Reply via email to