[
https://issues.apache.org/jira/browse/DIRSTUDIO-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888253#action_12888253
]
Kasun Lakpriya commented on DIRSTUDIO-677:
------------------------------------------
Added new method to check if a given String is a valid Java identifier or not
and added new tests for that method:
http://code.google.com/p/dirstudio-ldap-tooling/source/detail?r=63
> LdapEntryAnalyzer.computePackageName() issues
> ---------------------------------------------
>
> Key: DIRSTUDIO-677
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-677
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-persistence-tooling
> Reporter: Stefan Seelmann
> Assignee: Kasun Lakpriya
>
> - The method expects the parent DN. This is not intuitive, it would be better
> to pass the original DN and to compute the parent within the method.
> - When passing an empty DN (this happens if the entry's DN only has one name
> component) a StringIndexOutOfBounds exception is thrown.
> - There is no check if the package name is valid. For example if an RDN is
> "ou=External Users" the computed package name is "com.example.External
> Users".
> - Javadoc is missing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
