[jira] [Commented] (DIRKRB-225) Enhance kadmin to support modify principal

[Lin Chen (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DIRKRB-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513721#comment-14513721
 ] 

Lin Chen commented on DIRKRB-225:
---------------------------------

Hi Jiajia, a question:
In the codes below:
{code}
+                if (param != null) {
+                    kOption.setValue(param);
+                } else {
+                    error = "Option " + opt + " require a parameter";
+                }
{code}
Why not use {{KOptions.parseSetValue(kOption, param)}} just like {{kinit}} 
here? By that, we can chage codes below
{code}
+        if (kOptions.contains(KadminOption.EXPIRE)) {
+            KOption option = KadminOption.EXPIRE;
+            String strValue = kOptions.getStringOption(option);
+            KOptions.parseSetValue(option, strValue);
+            Date date = kOptions.getDateOption(option);
+            kid.setExpireTime(new KerberosTime(date.getTime()));
+        }
{code}
to
{code}
+        if (kOptions.contains(KadminOption.EXPIRE)) {
+             kid.setExpireTime(kOptions.getDateOption(KadminOption.EXPIRE));
+        }
{code}

> Enhance kadmin to support modify principal
> ------------------------------------------
>
>                 Key: DIRKRB-225
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-225
>             Project: Directory Kerberos
>          Issue Type: New Feature
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>         Attachments: DIRKRB-225-V1.patch, DIRKRB-225-V2.patch, 
> DIRKRB-225-V3.patch
>
>
> Enhance kadmin tool to support modify principal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)