[
https://issues.apache.org/jira/browse/DIRSTUDIO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559858#comment-14559858
]
Stefan Seelmann commented on DIRSTUDIO-1047:
--------------------------------------------
Thanks Paul for the patch. I just added an additional null check in LdifEditor
otherwise I got an NPE when opening the LDIF editor. Applied here:
http://svn.apache.org/r1681860
> No BrowserViewUniversalListener.connectionOpened null checks
> ------------------------------------------------------------
>
> Key: DIRSTUDIO-1047
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1047
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-ldapbrowser
> Affects Versions: 2.0.0-M8 (2.0.0.v20130628)
> Reporter: Paul Richardson
> Fix For: 2.0.0-M9
>
> Attachments: safeguard-browser-connections.diff
>
>
> BrowserViewUniversalListener.connectionOpened is fired on the opening of a
> connection. In my case, the connection being opened comes from a wizard
> displaying the BrowserWidget rather than the BrowserView. In this use-case,
> the BrowserConnection used in the wizard is only temporary so not added to
> the BrowserCorePlugin ConnectionManager.
> Consequently, opening a connection in the wizard while the BrowserView is
> also open, the latter's BrowserViewUniversalListener.connectionOpened() is
> fired and a NPE results.
> A check can be added to assert that the BrowserConnection fetched from the
> ConnectionManager is not null. Only if not null should the BrowserView viewer
> be refreshed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
