[
https://issues.apache.org/jira/browse/DIRKRB-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633822#comment-14633822
]
Lin Chen commented on DIRKRB-278:
---------------------------------
Hi Jiajia,
The patch looks great!
While as for me, I have a concern. {{KdcInitTool}} is just a tool, maybe it
need not to extents {{KdcServer}}? I wonder if it would be better to write like:
{code}
public KdcInitTool(File confDir) throws KrbException {
kdcServer = new KdcServer(confDir);
}
{code}
and
{code}
public void init() throws KrbException {
kdcServier.init();
......
}
{code}?
It's a problem about composition and inheritance. I could not figure it out.
Could you help me?
> Add kdcinit tool
> ----------------
>
> Key: DIRKRB-278
> URL: https://issues.apache.org/jira/browse/DIRKRB-278
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Jiajia Li
> Fix For: 1.0.0-RC1
>
> Attachments: DIRKRB-278-v1.patch
>
>
> This is to propose adding a new kdcinit tool that's to be used to initialize
> and prepare all kinds of KDC side materials, like initializing concrete back
> end, setting up master keys, necessary principals (tgs, kadmin) and etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
