[ 
https://issues.apache.org/jira/browse/DIRSERVER-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896890#comment-15896890
 ] 

Emmanuel Lecharny commented on DIRSERVER-2180:
----------------------------------------------

Hi Thilo-Alexander,

I have moved the code in a class, which remove the need of depending on the 
lib.I also applied a few push releases, one is bothersome : {{bcrypt}} is 
supposed to use {{$2y$}} instead of {{$2a$}} since 2011 (see 
https://en.wikipedia.org/wiki/Crypt_(C)#Blowfish-based_scheme).

I have one question : in you last commit, why have you added the following line 
? :

{noformat}
<suppress files="org.apache.directory.api.ldap.model.password.digest.BCrypt" 
checks="[a-zA-Z0-9]*"/>
{noformat}

> BCrypt password hashing support
> -------------------------------
>
>                 Key: DIRSERVER-2180
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2180
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>            Reporter: Thilo-Alexander Ginkel
>            Priority: Minor
>
> At the moment, Apache DS does not support the BCrypt password hashing 
> algorithm.
> As discussed on the dev mailinglist, I'd like to contribute support for this 
> algorithm and am opening this ticket as requested by [~elecharny]. An 
> incomplete prototype (at least OSGi tests are currently broken) is available 
> at [1].
> [1] 
> https://github.com/tgbyte/directory-shared/tree/feature/bcrypt-hash-support



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to