bdemers commented on PR #95: URL: https://github.com/apache/directory-scimple/pull/95#issuecomment-1199558095
Hey @smoyer64 I started a thread on the SCIMple list asking about this: https://lists.apache.org/thread/ds744czqo4j5j5vrot64o0309v0ffmyf My thinking behind merging them is, if typical usage of SCIMple (a client or server), is going to require both modules, merging them keeps things simple (less confusion for developers downstream, easier to refactor code within a package, etc) One minor downside of merging them is using the schema-related classes, which means there is an added dependency on `swagger-annotations`, but that doesn't have any [transitive dependencies](https://search.maven.org/artifact/io.swagger.core.v3/swagger-annotations/2.2.2/jar), so doesn't add much bloat. (And if typical usage requires both schema and protocol, that issues is moot anyway) That said, there are a few open questions from my original thread: * Is consumption of the server and client modules the most common usage of SCIMple. (I'm assuming this is the case, but would like to confirm) * A few classes in the protocol module needed to be moved to another (Java) package. Naming is hard, so I'm not sure this PR organizes them the best. My original thread suggested: - `org.apache.directory.scim.spec.core` - `org.apache.directory.scim.spec.protocol` Where this PR only moved the `protocol` classes. As for RFC7642, I don't think any code is directly needed for that RFC, as it's mostly background and use-cases. Though that probably would be good bases for integration tests (or a future compliance suite). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
