bdemers opened a new issue, #427: URL: https://github.com/apache/directory-scimple/issues/427
There are a couple gaps in the test coverage for `PatchGenerator`, specifically in the area of generating diffs for collections. Add tests common for ScimGroup patch operations: Modify displayName - REPLACE op add member(s) - ADD op remove member(s) - REMOVE op replace member(s) - when should this be used over multiple add/remove operations? e.g. 1 replace = 1 add + 1 remove ^ This is the tricky one, after a little poking around it looks like we need to change how we are using the JSON diff library. Take this use case for example: The original Group Resource has member refs: ``` yaml ... value: user1 ``` After being modifed, it has: ``` yaml ... value: user2 ``` This is actually the removal of User1, and the addition of User2, and NOT the replacement of the `value` field. For reference see: - https://github.com/apache/directory-scimple/pull/411#pullrequestreview-1748295568 - https://github.com/apache/directory-scimple/pull/411#discussion_r1404587890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
