kjthorpe18 opened a new issue, #436:
URL: https://github.com/apache/directory-scimple/issues/436

   The DefaultPatchHandler does not treat ScimGroup `members` as a collection, 
and removes the `members` attribute instead of the specified value.
   
   Example request:
   `PATCH /api/scim/v2/Groups/035a3341-5cc0-4abd-983b-d4540064afc6`
   ```json
   {
      "schemas":[
         "urn:ietf:params:scim:api:messages:2.0:PatchOp"
      ],
      "Operations":[
         {
            "op":"remove",
            "path":"members",
            "value":[
               {
                  "value":"aaebb169-b91d-481c-9957-097faeaf649a"
               }
            ]
         }
      ]
   }
   ```
   
   This request uses the DefaultPatchHandler's `RemoveOperationHandler`, and 
the method:
   ```java
   @Override
   public <T extends ScimResource> void applyMultiValue(T source, Map<String, 
Object> sourceAsMap, Schema schema, Attribute attribute, AttributeReference 
attributeReference, Object value) {
         checkMutability(attribute, sourceAsMap.get(attribute.getName()));
         // remove the collection
         sourceAsMap.remove(attribute.getName());
   }
   ```
   
   Rather than removing the whole collection, only the specified value should 
be removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

Reply via email to