+1 from me On Wed, Jan 17, 2024 at 1:21 PM Shawn McKinney <smckin...@apache.org> wrote: > > > > > On Jan 16, 2024, at 4:09 PM, Brian Demers <bdem...@apache.org> wrote: > > > > Hey All! > > > > Great questions added by Shawn! > > > > Hopefully I hit them all: > > > >> Guide to testing staged releases: > >> http://maven.apache.org/guides/development/guide-testing-releases.html > > > > This is optional, _techniall_ this is a guide explaining how to test > > the convenience binaries that will be deployed to Maven Central. > > I'm assuming most folks will use these binaries, (but officially, the > > ASF releases are source zip files) > > Which can be found: > >> https://repository.apache.org/service/local/repositories/orgapachedirectory-1224/content/org/apache/directory/scimple/scimple/1.0.0-M1/scimple-1.0.0-M1-source-release.zip > >> https://dist.apache.org/repos/dist/dev/directory/scimple/1.0.0-M1/ > > > >> Will there be a binary distribution? > > > > The source zip will be distributed via the official Apache Mirrors but > > the convenience binaries (jar files) will not be. > > > >> Are all of the transitive dependencies compatible w/ ASLv2 license? > > > > Another great question! I was ready to just say "yes" to this, but... > > there is one potential gray area when it comes to the test library. > > Here are a list of things that I spot checked: > > > > - Transitive "compile" scope dependencies of the client, server, and > > tools module. > > - Ensure no re-packaging happens in the example projects (e.g. > > creation of uber-jars, common for Spring Boot and Quarkus) > > - Checked licenses of jars repackaged in war file example > > - Test Library - SCIMple has a test module "scim-test" has a compile > > dependency on "JUnit", (This library can be used by SCIMple users to > > verify basic SCIM functionality works in their implementation). > > > > Per the ASF 3RD PARTY LICENSE POLICY [1], this seems fine (i'm not a > > lawyer), the EPL doesn't have an attribution clause, JUnit is not > > repackaged or distributed in a binary, and there IS notice in the jar > > in the `META-INF/DEPENDENCIES` file, and in the pom.xml. Consumers of > > this library would also need to explicitly configure those tests to > > run. > > > > We can/should spell this out more once we have a doc page describing > > how to add these tests to a custom project, but I don't think it's a > > problem with this release > > > > This is also similar to the Directory Server test module: > > org.apache.directory.server:apacheds-test-framework > > Though in that case the dependency is marked "provided" [2], and in > > SCIMple, it's "compile" > > > > We can do this in SCIMple too, (I'm happy to make this change[3] and > > re-spin the release if anyone thinks this should block) > > > > Fortress has junit scoped to test, perhaps that would work going forward. > > But, should be OK for this release. > > Thanks for the clarifications. Nice work. > > I’m a +1 for this release. Looks good to me. > > — > Shawn > > > [1] - https://www.apache.org/legal/resolved.html#category-b > > [2] - > > https://github.com/apache/directory-server/blob/bdbec41/test-framework/pom.xml#L76-L79 > > [3] - https://github.com/apache/directory-scimple/pull/501 >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
