[ 
https://issues.apache.org/jira/browse/DIRSERVER-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852325#comment-17852325
 ] 

Emmanuel Lécharny commented on DIRSERVER-2400:
----------------------------------------------

This is something that remained from a time we were using long instead of 
String for LDAP entry IDs.

I suspect we may have a few more of those guys in the code base.

Thanks for the report!

> Comparison of String objects
> ----------------------------
>
>                 Key: DIRSERVER-2400
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-2400
>             Project: Directory ApacheDS
>          Issue Type: Bug
>            Reporter: Artemii Voronin
>            Priority: Major
>             Fix For: 2.0.0.AM28
>
>
> Comparison of String objects using == or != in function 
> *computeSubLevelScope* in line №509. 
> [Link|https://github.com/apache/directory-server/blob/c347daec5cc1b14d98de01395c8be892b3db0c04/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/CursorBuilder.java#L503]
>  to this function. I consider it necessary to clarify with the developers if 
> they expect a comparison of string literals or pointers.
>  
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author A. Voronin (a.voro...@fobos-nt.ru).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

Reply via email to