Hi Emmanuel, The dist already had the Netty NOTICE part https://github.com/apache/directory-kerby/blob/trunk/kerby-dist/kdc-dist/NOTICE, and the license had jline + SLF4J https://github.com/apache/directory-kerby/blob/trunk/kerby-dist/kdc-dist/LICENSE
I added the missing jsch license Colm. On Wed, Aug 14, 2024 at 10:19 AM Colm O hEigeartaigh <[email protected]> wrote: > > Thanks everyone, that's 4 +1 votes, so I'll proceed with the release. > I'll address the license and README issues shortly. > > Colm. > > On Mon, Aug 12, 2024 at 4:37 PM Pierre Smits <[email protected]> wrote: > > > > Hi Colm, > > > > Ok. I guess there lies my issue. I did not execute 'mvn install' as I > > followed the instructions in Kerby Developer Guide. > > > > Having executed 'mvn install I got a successful build. > > > > Re: update the README > > This should not be a deal breaker. However, we should not forget to have > > the tickets created for the next (upcoming) releases in each of the sub > > projects. > > > > So here is my +1 regarding releasing this 2.1.0 version > > > > > > Met vriendelijke groet, best regards, > > > > Pierre Smits > > Proud contributor of Apache OFBiz since 2008 (without privileges) > > Proud contributor to the ASF since 2006 > > Apache Directory, PMC Member > > > > Anyone could have been you, whereas I've always been anyone. > > > > > > On Mon, Aug 12, 2024 at 4:24 PM Colm O hEigeartaigh <[email protected]> > > wrote: > >> > >> Thanks for checking Pierre. I tested with 'mvn install', what JDK are > >> you using? I will update the README, but after the release as I've > >> already cancelled the vote twice already to fix JDK issues. > >> > >> Colm. > >> > >> On Mon, Aug 12, 2024 at 12:44 PM Pierre Smits <[email protected]> > >> wrote: > >> > > >> > Hi Colm, > >> > > >> > I downloaded the zip file regarding the 2.1.0 tag. After unzipping I > >> > executed: > >> > > >> > mvn clean > >> > mvn compile > >> > > >> > The second task resulted in following error: > >> > [INFO] BUILD FAILURE > >> > [INFO] > >> > ------------------------------------------------------------------------ > >> > [INFO] Total time: 57.539 s > >> > [INFO] Finished at: 2024-08-12T13:26:24+02:00 > >> > [INFO] > >> > ------------------------------------------------------------------------ > >> > [ERROR] Failed to execute goal on project integration-test: Could not > >> > resolve dependencies for project > >> > org.apache.kerby:integration-test:jar:2.1.0: Could not find artifact > >> > org.apache.kerby:kerb-kdc-test:j > >> > ar:tests:2.1.0 in central (https://repo.maven.apache.org/maven2) -> > >> > [Help 1] > >> > [ERROR] > >> > > >> > Maybe I did something wrong, but at the moment it is unclear what... > >> > But executing 'mvn test' resulted in success. > >> > > >> > > >> > I also had a read through the README.md file. The content is a bit out > >> > of date, as the latest release info in there the releases stops at > >> > release 1.1.0. IMO, we should have this addressed prior to asking for a > >> > vote. > >> > > >> > Met vriendelijke groet, > >> > > >> > Pierre Smits > >> > Proud contributor of Apache OFBiz since 2008 (without privileges) > >> > Proud contributor to the ASF since 2006 > >> > Apache Directory, PMC Member > >> > > >> > Anyone could have been you, whereas I've always been anyone. > >> > > >> > > >> > On Mon, Aug 12, 2024 at 10:08 AM Colm O hEigeartaigh > >> > <[email protected]> wrote: > >> >> > >> >> I need another +1 on this vote from someone please... > >> >> > >> >> Colm. > >> >> > >> >> On Fri, Aug 2, 2024 at 2:32 PM Shawn McKinney <[email protected]> > >> >> wrote: > >> >> > > >> >> > > >> >> > > >> >> > > On Aug 2, 2024, at 3:56 AM, Colm O hEigeartaigh > >> >> > > <[email protected]> wrote: > >> >> > > > >> >> > > This is a vote to release Apache Kerby 2.1.0. The main features are > >> >> > > the removal of the HAS project, which was not maintained, and > >> >> > > updates > >> >> > > to the LDAP API and Directory Server versions. I've tested it with > >> >> > > the > >> >> > > CXF Kerberos system tests and it's fine. > >> >> > > > >> >> > > Since the last vote I've fixed the integration tests so that it > >> >> > > works > >> >> > > with JDK 17. > >> >> > > > >> >> > > Issues fixed: > >> >> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310910&version=12346557 > >> >> > > Git tag: > >> >> > > https://github.com/apache/directory-kerby/tree/kerby-all-2.1.0 > >> >> > > Artifacts: > >> >> > > https://repository.apache.org/content/repositories/orgapachedirectory-1231/ > >> >> > > > >> >> > > +1 from me. > >> >> > > >> >> > Lastest batch looks good! I’m now a + 1 > >> >> > > >> >> > Thanks > >> >> > > >> >> > — > >> >> > Shawn > >> >> > > >> >> > > > >> >> > > Colm. > >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
