bdemers commented on issue #559:
URL:
https://github.com/apache/directory-scimple/issues/559#issuecomment-2290550662
I've been kicking a few things around in the back of my head related to this
for a while.
The big one was validation via Jakarta Validation.
There are a few annotations present on some of the resources, but it's
minimal.
My thought was we _should_ be able to process validations based on the
`@ScimAttribute` annotation.
This is possible, but it's probably overkill... There were two options:
1. Mix concerns/implementations, and turn `@ScimAttribute` into a valid
Jakarta validation annotation.
This added additional fields to the annotation, which I didn't think
belonged there, it increased the complexity of that annotation, and I think it
makes it more difficult for a user.
2. Define Validation in XML
I created an Annotation processor that created a constraints XML file
that configures the basic `@NotNull` and `@Size(min=1)` annotations.
Usage wise, this is probably the cleanest, we could make it _just work_.
The downside is, this would a bunch of code for _probably_ little value.
~1000 loc (with my poorly testing prototype)
All that to save us (and any custom extensions) from needing to add a
couple of annotations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
