coheigea commented on PR #339: URL: https://github.com/apache/directory-server/pull/339#issuecomment-4334034995
Hi Emmanuel, This change is coming from the removal of the NoVerificationTrustManager in the LDAP API that was done recently. So to get the Directory Server tests to pass, I copied it into some of the test modules. In addition, the removal broke the "strictCertVerification" setting. So now it just defaults to "strict" and if you want lax you have to plug in your own TrustManager class name via "trustManagerFQCN". IMO this is reasonable, we don't need to allow an easy way to turn off TLS certificate checks by default, in the same way that it was removed from the API. However if you really think we should keep it as it was, I can add NoVerificationTrustManager back internally to the directory server. By the way the PR comments out 3 tests that were broken by the commit https://github.com/apache/directory-ldap-api/commit/e8c9eae4215b8481b9e5a14c2a0dbd472317f580 relating to the Antlr parsing change. Colm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
