coheigea opened a new pull request, #337: URL: https://github.com/apache/directory-ldap-api/pull/337
When a connection goes back to the pool, the pool re-binds it with its own configured identity if the borrower issued a bind. It relies on MonitoringLdapConnection to see those binds. That class covered every bind variant except bind(SaslRequest). After a borrower did a SASL bind as another user, the pool didn't notice. The connection went back still logged in as that user, and the next borrower silently got their access rights. The patch adds the missing bind(SaslRequest) override, so SASL binds are tracked like every other bind and the pool's identity is restored on release. Both pool factories use this class, so both are fixed. There are new tests for the monitor itself and for the full borrow → SASL bind → release path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
