opravil-jan commented on PR #117: URL: https://github.com/apache/directory-studio/pull/117#issuecomment-5887012013
Converting to draft: commits 1 and 3 are based on the wrong tokenizer. They follow `strtok_quote()` (slapd.conf), where a backslash escapes the next character. But `olcSyncrepl` in cn=config / slapd.d is tokenized by `strtok_quote_ldif()`, which passes backslashes (and all other characters) through unchanged. As it stands, commit 3 would save `(cn=a\2ab)` as `(cn=a\\2ab)`, which is a regression. I'll rework it so backslashes are kept verbatim when parsing and are not escaped when writing, then mark the PR ready again. The `tls_cacertdir` fix (commit 2) is unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
