GitHub user franckcuny opened a pull request: https://github.com/apache/incubator-distributedlog/pull/46
Update a couple of scripts Mostly style. You can merge this pull request into a Git repository by running: $ git pull https://github.com/franckcuny/incubator-distributedlog fcuny/update-scripts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 ---- commit 4f81ba23af8867af8b5f5afeaca86e5b2e255489 Author: Franck Cuny <fc...@apache.org> Date: 2016-11-17T04:11:57Z Rely on git to find the root directory. Using `rev-parse --show-toplevel` we can find the top directory. Since we've set the '-e' option for bash, if we're not in a git repository this will fail (which is what we want). Add a few quotes and upper case a variable. commit 85aa8a789c3b99f71d6fd64c960dd7bd4ffa438d Author: Franck Cuny <fc...@apache.org> Date: 2016-11-17T04:13:39Z Make the shell style more consistent. The style was inconsistent, using sometimes 4 spaces or 2 spaces for indentation; using 'then' on the same line or another line; some variables were quoted correctly; etc. The style is now consistent and it's easier to read the script. Instead of blindly running `sysctl`, only do it if we're on Linux. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---