[ https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714403#comment-15714403 ]
ASF GitHub Bot commented on DL-80: ---------------------------------- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/48 DL-80 : synchronized getLogRecordSetWriter() see jira's comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-80 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 ---- commit fc999fb57be8bc38390a5d1771ec8974e5fb54f3 Author: xieliang <xieliang...@gmail.com> Date: 2016-12-02T07:50:20Z synchronized getLogRecordSetWriter() ---- > recordSetWriter has multi-thread issue > -------------------------------------- > > Key: DL-80 > URL: https://issues.apache.org/jira/browse/DL-80 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client > Affects Versions: 0.4.0 > Reporter: Liang Xie > > Reading code, found there's a minor issue in DistributedLogMultiStreamWriter > class. Currenty only flush()&write() have *synchronized*, but > getLogRecordSetWriter miss the protection. so it would be possible get an > obsolete writer just after flush() happened. -- This message was sent by Atlassian JIRA (v6.3.4#6332)