[
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742977#comment-15742977
]
ASF GitHub Bot commented on DL-129:
-----------------------------------
Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025594
--- Diff: distributedlog-build-tools/pom.xml ---
@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
--- End diff --
I like the idea to organize the checkstyle files into a separated module so
that we don't need to have configuration on each module.
I think we should do the similar thing for findbugs settings. Can you move
the findbug settings to builds-tool module? (It can be a separate jira and pull
request).
Also it might be clear to move the eclipse format settings and the merge-pr
script to builds-tool module too.
> Enable check style for distributedlog-protocol module
> -----------------------------------------------------
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
> Issue Type: Sub-task
> Components: distributedlog-protocol
> Reporter: Xi Liu
> Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
