[ 
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-136:
-------------------------
    Labels: help-wanted  (was: )

> Avoid empty catch blocks
> ------------------------
>
>                 Key: DL-136
>                 URL: https://issues.apache.org/jira/browse/DL-136
>             Project: DistributedLog
>          Issue Type: Task
>            Reporter: Sijie Guo
>              Labels: help-wanted
>
> Based on the code analysis here : 
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22 
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException, 
> KeeperException, Exception, etc.. Even though we think that these exceptions 
> should never occur, if they are captured it means that they are technically 
> possible. In case that they do happen, it will be very difficult to know what 
> is happening and to diagnose the problem. It is very recommendable, at least 
> to add a log trace, in case these exceptions are triggered.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to