[
https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755344#comment-15755344
]
ASF GitHub Bot commented on DL-122:
-----------------------------------
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/77
DL-122: Use assertions from Junit rather than assert() for tests
* changed all instances of `assert()` to junit versions in `src/test`
Here is the script I used to find all instances of `assert()` inside the
`src/test` folder:
```
grep -r "assert(" * 2>/dev/null | grep -v "main"
```
The `grep -v "main"` removes all instances of the usage within the main
source tree (which there are quite a few). I did this as I assumed the JIRA
ticket spirit was not to remove those instances from the main tree and thus
would require including `junit` in core compilation rather than scoped for
`test` as is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit d95c57afe627f73b0e98a0a6b11db59f07eccfd5
Author: Brennon York <[email protected]>
Date: 2016-12-16T19:38:20Z
changed all instances of assert() to junit versions in src/test
----
> Use assertions from Junit rather than assert() for tests
> --------------------------------------------------------
>
> Key: DL-122
> URL: https://issues.apache.org/jira/browse/DL-122
> Project: DistributedLog
> Issue Type: Bug
> Components: distributedlog-core
> Reporter: Gerrit Sundaram
> Assignee: Brennon York
>
> there are too many places in test using 'assert()' rather than using
> assertions from junit. it would be good that we can change that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
