Thank you Henry. I will check and fix them. - Sijie
On Tue, Jan 31, 2017 at 8:40 AM, Henry Saputra <henry.sapu...@gmail.com> wrote: > For license header file, it is the wrong header for Apache project. > > The ones we have currently is for external projects that use Apache license > 2.0. > > The format need to be: > > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ /* * Licensed to the Apache Software Foundation (ASF) under one * or > more contributor license agreements. See the NOTICE file * distributed with > this work for additional information * regarding copyright ownership. The > ASF licenses this file * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance * with the > License. You may obtain a copy of the License at * * > http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by > applicable law or agreed to in writing, software * distributed under the > License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR > CONDITIONS OF ANY KIND, either express or implied. * See the License for > the specific language governing permissions and * limitations under the > License. */ > > On Mon, Jan 30, 2017 at 6:22 PM, Sijie Guo <si...@apache.org> wrote: > > > The release is rejected by IPMC. There are 3 issues: > > > > - missing disclaimer file : > > https://github.com/apache/incubator-distributedlog/pull/120 > > - notice file year is wrong: > > https://github.com/apache/incubator-distributedlog/pull/119 > > - copyright year is wrong: > > https://github.com/apache/incubator-distributedlog/pull/121 > > > > We need to address these issues and cut another RC. > > > > Can anyone review these? It would be great if the mentors can take a look > > at those fixes too. > > > > - Sijie > > >
