+1 - packages and license headers look good - run the build and tests
- gs On Mon, Apr 3, 2017 at 11:04 AM, Stevo Slavić <ssla...@gmail.com> wrote: > +1 (non-binding) > > On Mon, Apr 3, 2017 at 5:37 PM, Xi Liu <xi.liu....@gmail.com> wrote: > > +1 > > - verified packages (md5, asc and sha1 all look good) > - the source package can compile > - I followed the tutorials to run with the binary packages. all look good. > - NOTICE, DISCLAIME, License headers look good. > > - Xi > > On Sun, Apr 2, 2017 at 7:01 PM, Leigh Stewart <lstew...@twitter.com.invalid > > > wrote: > > > +1 > > > > On Mar 31, 2017 11:03 AM, "Yiming Zang" <yz...@twitter.com.invalid> > wrote: > > > > > +1 > > > > > > Same as Jia Zhai, build succeed after adding > > > "<exclude>src/main/resources/DISCLAIMER.bin.txt</exclude>" > > > at line 232 of pom.xml > > > > > > MD5 and SHA looks good. > > > > > > dlog tool can run without any issue from the binary. > > > > > > > > > On Thu, Mar 30, 2017 at 5:27 PM, Jia Zhai <zhaiji...@gmail.com> wrote: > > > > > > > +1 binding. > > > > > > > > "mvn apache-rat:check package findbugs:check -DskipTests" execute > > > > successfully, after exclude 1 file for rat check, by adding this line > > at > > > > line232 of pom.xml > > > > ``` > > > > <exclude>src/main/resources/DISCLAIMER.bin.txt</exclude> > > > > ``` > > > > > > > > On Thu, Mar 30, 2017 at 12:46 AM, Sijie Guo <guosi...@gmail.com> > > wrote: > > > > > > > > > I think apache-rat:check will fail because of > > > > > https://issues.apache.org/jira/browse/DL-195. But I don't think it > > is > > > a > > > > > blocker for the release. > > > > > > > > > > - Sijie > > > > > > > > > > On Tue, Mar 28, 2017 at 3:29 PM, Sijie Guo <guosi...@gmail.com> > > wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > Please review and vote on the release candidate #3 for the > version > > > > 0.4.0, > > > > > > as follows: > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > > > > > > > * JIRA release notes [1], > > > > > > * the official Apache source release to be deployed to > > > > > dist.apache.org > > > > > > [2], > > > > > > * all artifacts to be deployed to the Maven Central > Repository > > > [3], > > > > > > * source code tag "v0.4.0-incubating-RC1_2.11" (for scala > 2.11) > > > and > > > > > > "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [4][5], > > > > > > * website pull request listing the release [6] and publishing > > the > > > > API > > > > > > reference manual. > > > > > > > > > > > > A simple instruction for validation the source and binary > packages. > > > > > > > > > > > > - source package: building the package with "*mvn clean > > > > apache-rat:check > > > > > > package findbugs:check -DskipTests*" > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > majority > > > > > > approval, with at least 3 PPMC affirmative votes. > > > > > > > > > > > > Thanks, > > > > > > Sijie > > > > > > > > > > > > [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > > > version=12337980&styleName=&projectId=12320620 > > > > > > [2] https://dist.apache.org/repos/dist/dev/incubator/ > > > > > distributedlog/0.4.0- > > > > > > incubating-RC3/ > > > > > > [3] https://repository.apache.org/content/repositories/ > > > > > > orgapachedistributedlog-1006/ > > > > > > [4] https://github.com/apache/incubator-distributedlog/tree/ > > > > > > v0.4.0-incubating-RC3_2.11 > > > > > > [5] https://github.com/apache/incubator-distributedlog/tree/ > > > > > > v0.4.0-incubating-RC3_2.10 > > > > > > [6] https://github.com/apache/incubator-distributedlog/pull/109 > > > > > > > > > > > > > > > > > > > > >
