HI Sijie, I will be out for this week with limited access to Internet.
But will take a look at the PR. - Henry On Tue, Apr 11, 2017 at 11:10 AM, Sijie Guo <guosi...@gmail.com> wrote: > I created https://issues.apache.org/jira/browse/DL-198 for combining those > asf files. > > https://github.com/apache/incubator-distributedlog/pull/128 is out for > review. > > Can mentors take a look to make sure I am doing the right thing for asf > files? > > - Sijie > > On Mon, Apr 10, 2017 at 11:52 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > I think this is doable - we can change the binary package assembly > > configuration (src/assemble/bin/xml) to include NOTICE/DISCLAIMER/LICENSE > > from root directly. > > > > Let me file one JIRA and send out a pull request for it. > > > > - Sijie > > > > On Mon, Apr 10, 2017 at 5:02 PM, Henry Saputra <henry.sapu...@gmail.com> > > wrote: > > > >> Hi All, > >> > >> Seemed like we have 2 locations of the ASF license files: > >> > >> one in the root > >> and one in src/main/resources > >> > >> The problem is that content of the files are different. > >> > >> Could we change the build system to bundle them using the ones in root > >> location instead? > >> > >> Thanks, > >> > >> - Henry > >> > > > > >
