+1 - packages look good (verified md5, asc and shall) - compiled the source packages - be able to run dlog with the binary packages.
On Sat, Apr 15, 2017 at 11:53 AM, Yiming Zang <yz...@twitter.com.invalid> wrote: > +1 (non-binding) > Verify both 2.10 and 2.11: > 1. md5, sha1, asc looks good > 2. The source package compile successfully > 3. dlog tool run successfully > > > On Thu, Apr 13, 2017 at 10:55 AM, Xi Liu <xi.liu....@gmail.com> wrote: > > > +1 (non-binding) > > > > - verified packages (md5, asc and sha1 all look good) > > - the source package can compile > > - I followed the tutorials to run with the binary packages. all look > good. > > - NOTICE, DISCLAIME, License headers look good. > > > > On Thu, Apr 13, 2017 at 4:51 AM, Jia Zhai <zhaiji...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > for both distributedlog_2.10 and distributedlog_2.11: > > > - verified packages (md5, asc and sha1 all look good) > > > - the source package build and test all run successfully. > > > - NOTICE, DISCLAIME, License headers look good. > > > > > > > > > On Thu, Apr 13, 2017 at 3:36 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > > > > > Hi all, > > > > > > > > Please review and vote on the release candidate #4 for the version > > 0.4.0, > > > > as follows: > > > > > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > > > > > * JIRA release notes [1], > > > > * the official Apache source release to be deployed to > > > dist.apache.org > > > > [2], > > > > * all artifacts to be deployed to the Maven Central Repository > > > [3][4], > > > > * source code tag "v0.4.0-incubating-RC4_2.11" (for scala 2.11) > and > > > > "v0.4.0-incubating-RC4_2.10" (for scala 2.10) [5][6], > > > > * website pull request listing the release [7] and publishing the > > API > > > > reference manual. > > > > > > > > A simple instruction for validation the source and binary packages. > > > > > > > > - source package: building the package with "*mvn clean > > apache-rat:check > > > > package findbugs:check -DskipTests*" > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PPMC affirmative votes. > > > > > > > > Thanks, > > > > Sijie > > > > > > > > [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > version=12337980&styleName=&projectId=12320620 > > > > [2] > > > > https://dist.apache.org/repos/dist/dev/incubator/ > distributedlog/0.4.0- > > > > incubating-RC4/ > > > > [3] > > > > https://repository.apache.org/content/repositories/ > > > > orgapachedistributedlog-1007/ > > > > [4] > > > > https://repository.apache.org/content/repositories/ > > > > orgapachedistributedlog-1008/ > > > > [5] > > > > https://github.com/apache/incubator-distributedlog/tree/ > > > > v0.4.0-incubating-RC4_2.11 > > > > [6] > > > > https://github.com/apache/incubator-distributedlog/tree/ > > > > v0.4.0-incubating-RC4_2.10 > > > > [7] https://github.com/apache/incubator-distributedlog/pull/109 > > > > > > > > > >