LGTM. Could you kickoff another VOTE thread for v2.1 RC 1 then?
Thanks, - Henry On Fri, Mar 8, 2019 at 1:20 AM Bohdan Hliva <bohdan_hl...@epam.com.invalid> wrote: > Hi Henry, > > Changes are in v2.1 branch > https://github.com/apache/incubator-dlab/tree/v2.1 > > > > > BOHDAN HLIVA > Lead Software Engineer > > Office: +380 322 424 642 x 42572 Cell: +380 63 151 2201 Email: > bohdan_hl...@epam.com<mailto:bohdan_hl...@epam.com> > Lviv, Ukraine epam.com<http://epam.com> > > CONFIDENTIALITY CAUTION AND DISCLAIMER > This message is intended only for the use of the individual(s) or > entity(ies) to which it is addressed and contains information that is > legally privileged and confidential. If you are not the intended recipient, > or the person responsible for delivering the message to the intended > recipient, you are hereby notified that any dissemination, distribution or > copying of this communication is strictly prohibited. All unintended > recipients are obliged to delete this message and destroy any printed > copies. > > > On Mar 7, 2019, at 21:56, Henry Saputra <henry.sapu...@gmail.com<mailto: > henry.sapu...@gmail.com>> wrote: > > Sorry I missed this email due to massive JIRA update emails. > > Has the changes committed to master branch? > > - Henry > > On Thu, Feb 28, 2019 at 5:13 AM Bohdan Hliva <bohdan_hl...@epam.com.invalid > <mailto:bohdan_hl...@epam.com.invalid>> > wrote: > > Dear mentors, > > I have some questions regarding release: > 1. Release headers: > > * All headers are updated as described here > http://www.apache.org/legal/src-headers.html; > * There are some files in source code that does not support comments: > e.g. .json, .txt, .ipynb, some config files etc. How to be with such files? > > 2. Notice and License files are also updated. Could you please check > whether it correct or not? > 3. There also was a note regarding provenance of picture that we use for > test purpose. Should we include some link of source from which it was > downloaded? > 4. Compiled code exists in source release. Should we store it somewhere > separately? > > Thanks in advance! > > >
