ofuks commented on a change in pull request #842:
URL: https://github.com/apache/incubator-dlab/pull/842#discussion_r466462253
##########
File path:
services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##########
@@ -344,10 +344,11 @@ private String getUpdateBudgetAudit(ProjectDTO p) {
if (!configuration.isAuditEnabled()) {
return null;
}
- Integer value =
Optional.ofNullable(get(p.getName()).getBudget())
+ ProjectDTO dbProject = get(p.getName());
+ Integer value = Optional.ofNullable(dbProject.getBudget())
.map(BudgetDTO::getValue)
.orElse(null);
- boolean monthlyBudget =
get(p.getName()).getBudget().isMonthlyBudget();
+ boolean monthlyBudget = dbProject.getBudget().isMonthlyBudget();
Review comment:
Can this line cause NPE?
##########
File path:
services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##########
@@ -344,10 +344,11 @@ private String getUpdateBudgetAudit(ProjectDTO p) {
if (!configuration.isAuditEnabled()) {
return null;
}
- Integer value =
Optional.ofNullable(get(p.getName()).getBudget())
+ ProjectDTO dbProject = get(p.getName());
Review comment:
Please rename **dbProject** to **project** or **projectDTO**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@dlab.apache.org
For additional commands, e-mail: dev-h...@dlab.apache.org
