Very good proposal! Very glad to see new proposal after meetup. Here are some questions: 1. About the bar of UT. I thought now UT is below 40%, totally agree to improve that. Other people opinion? 2. I noticed that you mentioned some AWS Servers to support this CICD process. How many extra resource besides Apache offered do you need if we want to finish this CICD. 3. I am curious about license check. Do we have some way to do it automatically or semi-auto way?
William Guo Wei ------------------ Original ------------------ From: Xiaochun Liu <[email protected]> Date: Mon,Dec 9,2019 8:47 PM To: dev <[email protected]> Subject: Re: [Proposal] Improve CI / CD process Hi, all, the CI / CD process in DolphinScheduler only has build check and license check. The other parts are missing now. Here is my proposal: The overall idea of ?6?7?6?7CI / CD is shown in the following graph. There are two main triggering methods, submitting PR / MR trigger and night time trigger. The night time trigger triggers to run once a day, and the task is relatively heavy. The content of CI / CD to be tested or checked is shown in the graph below. The above is my overall thinking. The details of the CI / CD plan for the next version are as follows: 1) The ut needs to be improved. The goal of the proportion of UT is to reach 60%. At least the newly added PR cannot be lower than this. If it feels unreasonable, we can vote to discuss it. The modules involved in this supplementary UT are api server, common, alert, and some master and worker UTs. 2) checkstyle check, there are two kinds of google and Alibaba, personal preference is alibaba (more comprehensive), this can be discussed separately 3) spotbugs check 4) Front-end eslint check 5) Coveralls code coverage report. When submitting a PR, it will be automatically displayed in the comments, showing the impact of the new part on the current code coverage, and the current test coverage will be displayed on the github home page. If have other ideas, we can discuss together ~~ Thank you Xiaochun Liu [email protected]
