Hi hgaol,
Sorry for not replying in time.
I saw you added the module dolphinscheduler-plugin-api and examples module,here
are my two points want to discuss.
1、Whether the function of module dolphinscheduler-plugin-api can be puted in
the alert module.
2、I think the examples module can be a folder.
DolphinScheduler(Incubator) PPMC
Gang Li 李岗
[email protected]<mailto:[email protected]>
From: hgaol
Date: 2020-04-29 23:37
To: dev
Subject: Re: [PROPOSAL][Feature] Support plugin in Alert service
Hi folks,
I’ve created a PR for this feature, here is the link
https://github.com/apache/incubator-dolphinscheduler/pull/2572
<https://github.com/apache/incubator-dolphinscheduler/pull/2572>
Feel free to let me know if there is any suggestion.
Thanks,
Han Gao
> On Apr 28, 2020, at 15:25, xingchun.chen <[email protected]> wrote:
>
> It sounds very good, looking forward to your contribution
>
>
> best wish!
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "hgaol"<[email protected]>;
> 发送时间: 2020年4月28日(星期二) 下午3:11
> 收件人: "dev"<[email protected]>;
>
> 主题: [PROPOSAL][Feature] Support plugin in Alert service
>
>
>
> Hi folks,
>
> I think it will be useful for Alert service supporting the plugin management.
> I’ve create an issue in Github and described about it, here
> <https://github.com/apache/incubator-dolphinscheduler/issues/2553> is the
> link. Copy here for convenience.
>
> > I think the plugin feature is needed by the customers, because different
> user may have different environment. For example, I want to use SMS to send
> alert information, but the SMS API is provided by some system we don't know
> before, and our DS has already deployed. In this case, I just want to
> implement the plugin code, and don't change the source code.
> >
> > Another benefits are developers can implement different plugin, like
> slack, wechat, telegram, github issue, and etc...
> >
> > Describe the solution you'd like
> > A clear and concise description of what you want to happen.
> >
> > A better way is that user do not need to change the source code to
> support new alert method. Instead, they just need to implement some
> interface, and compliance with the convention, then package all(include
> dependencies) in a single jar file, and put the jar file in some specific
> place, such as $DS_HOME/plugins. After that, when start Alert service, the
> plugins can be recognized and loaded. So user can choose the alert method in
> the portal.
> >
> > Currently, I've done some investigations, and if this feature is
> accepted, I think maybe I can implement it.
> >
> > Firstly, I'd better to adapt the current function, which is send mail
> and something like that.
> >
> > Then, we can add some more features, such as Alert handler instance,
> which is created to describe the alert information(email/slack/wechat/..., to
> whom, the title, content, and etc…).
> >
> > BTW, email and webhook are used frequently. I think they can be the
> default plugin, and written in the source code, instead of a jar file.
>
> Thanks,
> hgaol
