Great job! Jiajie Zhong <[email protected]> 于2022年3月22日周二 21:46写道：
> Hi guys, > > I am here to let you know that this problem had been solved by PR-8999[1]. > > For now, when the user run command `mvn install package -Prelease` or > other commands with any single `release` profile will not build Python > distribute package. > > It will only build Python dist package if you specific `python` > profile. such as `mvn install package -Ppython`, or multiple profiles > which including `python` like `mvn install package -Prelease,python`. > > Thanks ZhenXu again. > > [1]: https://github.com/apache/dolphinscheduler/pull/8999 > > On Fri, Mar 18, 2022 at 10:32 AM Jiajie Zhong <[email protected]> > wrote: > > > > Sound great! I will try to separate Python into a different profiles, > thanks! > > > > On Thu, Mar 17, 2022 at 9:30 PM kezhenxu94 <[email protected]> > wrote: > > > > > > Sounds reasonable not to build everything by default. However in order > to be able to build the Python module with ease (for people who use it or > for developers to verify), we can introduce a maven profile to build it > conditionally, for example ./mvnw package -Ppython > > > > > > > > > > > > > On Mar 17, 2022, at 19:16, Jiajie Zhong <[email protected]> > wrote: > > > > > > > > Hey guys, > > > > > > > > I start a thread to discuss should we remove build Python distribute > when users > > > > build package with comamdn `mvn install package -Prelease`? > > > > > > > > For now, in dev branch, run commd `mvn install package -Prelease` > will > > > > build Python > > > > distribute package locally, and it requires users have Python in > their > > > > environment and > > > > command `python` work in terminal. I add it by PR[1] because I find > > > > other Apache project > > > > which have Python API, also released Python API distribute package > > > > with the main project, > > > > See issue-8343[2] for more details. > > > > > > > > However, some users have reported that it is not user friendly to ask > > > > to have Python in > > > > environment to get the binary packages. Specially some users have > > > > integrated the upgrade > > > > stepinto the CD tool, such as Jenkins. And they expect to get the > > > > latest binary packages > > > > with as few dependencies as possible. > > > > > > > > I think it make sense because most of users do not use Python API(at > > > > least for now). If I am > > > > the user who do not use Python API, I also do not want to add > > > > dependencies for building > > > > package. But we release Python binary package together with main > > > > distirbute, it looks more professional. > > > > > > > > So do your guys think we should remove Python dependencies in > building > > > > process or keep it? > > > > please share your ideas in this thread thanks > > > > > > > > [1]: https://github.com/apache/dolphinscheduler/pull/8470 > > > > [2]: https://github.com/apache/dolphinscheduler/issues/8343 > > > > > > > > -- > > > > Best Wish > > > > — Jiajie > > > > > > > > -- > > Best Wish > > — Jiajie > > > > -- > Best Wish > — Jiajie > -- ------------------------------ Best Regards DolphinScheduler PMC Gang Li 李岗 [email protected]
