can't agree more +1
Best Regards --------------- Apache DolphinScheduler PMC Chair & Apache SeaTunnel PPMC Lidong Dai [email protected] Linkedin: https://www.linkedin.com/in/dailidong Twitter: @WorkflowEasy <https://twitter.com/WorkflowEasy> --------------- On Mon, Mar 7, 2022 at 6:57 PM Jiajie Zhong <[email protected]> wrote: > BTW, I found out we have some pull requests[1][2] that have a long > description > and can not display oneline in GitHub > > I think we should also avoid this too. Make we should make our PR title > keep in > oneline sentence. Or maybe we should just remove the prefix > `[V1.0.0-Alpha]` which > I think it could use a label to do it. > > cc: our frontend developers > > [1]: https://github.com/apache/dolphinscheduler/pull/8739 > [2]: https://github.com/apache/dolphinscheduler/pull/8738 > > On Mon, Mar 7, 2022 at 6:48 PM Jiajie Zhong <[email protected]> > wrote: > > > Hey guys, > > > > I found out in our latest release[1], we have a bug fix like > > > > `[#8367] Fixed complement may not end normally` > > > > which is an uncertain message for users, And I think we should avoid > > using the uncertainty word. Users will read our release note to decide > > whether they should upgrade to the latest version. > > > > Having exciting features is certainly a great motivation for them to > > upgrade. > > But the bugfix is also very important to them. If our bugfix title with > > uncentainly > > words like "maybe fix", "fix the situation may appear" will not only make > > our > > project not professional, but also with lose new users or early-bird > users > > for the > > latest release version. > > > > So I am here proposal we should avoid the uncertainty word, for all > > developer, > > > > **especially the committer**. When committers review and merge the pull > > requests > > > > you should be careful and should change the pull requests title if it > > should change. > > > > It is our duty and we are the last line of defense for our git log > > > > [1]: https://github.com/apache/dolphinscheduler/releases/tag/2.0.5 > > > > -- > > Best Wish > > — Jiajie > > > > > -- > Best Wish > — Jiajie >
