kangkaisen commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r231748118
##########
File path:
fe/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
##########
@@ -44,9 +45,15 @@ public void analyze(Analyzer analyzer) throws
AnalysisException {
throw new AnalysisException("Properties is not set");
}
- if
(!Catalog.getCurrentCatalog().getAuth().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ALTER)) {
+ if (properties.size() == 1 &&
properties.containsKey(KEY_COLOCATE_WITH)) {
Review comment:
Yes. it's reasonable user could later table colocate_with property. but
require a global ALTER Privilege is not reasonable. normal users shouldn't have
global ALTER Privilege, if they have, they will could read all dbs. I tested
it. So we should check db level Privilege not global Privilege.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
