lide-reed commented on a change in pull request #305: Improve build script
URL: https://github.com/apache/incubator-doris/pull/305#discussion_r233322529
##########
File path: env.sh
##########
@@ -53,12 +64,21 @@ if ! ${PYTHON} --version; then
export PYTHON=python2.7
if ! ${PYTHON} --version; then
echo "Error: python is not found"
- exit
+ exit 1
fi
fi
-# set DORIS_THIRDPARTY
-if [ -z ${DORIS_THIRDPARTY} ]; then
- export DORIS_THIRDPARTY=${DORIS_HOME}/thirdparty
+# set GCC HOME
+if [[ -z ${DORIS_GCC_HOME} ]]; then
+ # specify your GCC HOME if needed
+ export DORIS_GCC_HOME=$(dirname `which gcc`)/..
+fi
+
+gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpversion`
+required_ver="5.3.1"
+if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" =
"$required_ver" ]]; then
+ echo "Error: GCC version (${gcc_ver}) must be greater than or equal to
${required_ver}"
+ echo "DORIS_GCC_HOME is need to be set in env.sh after you installed a new
version of GCC."
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
