morningman closed pull request #362: Fix snapshot's making header bug
URL: https://github.com/apache/incubator-doris/pull/362
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/be/src/olap/olap_snapshot.cpp b/be/src/olap/olap_snapshot.cpp
index ab2c7c0c..8323aa08 100644
--- a/be/src/olap/olap_snapshot.cpp
+++ b/be/src/olap/olap_snapshot.cpp
@@ -377,15 +377,6 @@ OLAPStatus OLAPEngine::_create_snapshot_files(
header_locked = false;
_update_header_file_info(shortest_versions, new_olap_header);
- // save new header
- if ((res = OlapHeaderManager::save(store, ref_olap_table->tablet_id(),
- ref_olap_table->schema_hash(), new_olap_header)) !=
OLAP_SUCCESS) {
- LOG(WARNING) << "save header error. [table=" <<
ref_olap_table->full_name()
- << "tablet_id=" << ref_olap_table->full_name()
- << ", schema_hash=" << ref_olap_table->schema_hash();
- break;
- }
-
// save new header to snapshot header path
res = new_olap_header->save(header_path);
if (res != OLAP_SUCCESS) {
@@ -791,8 +782,6 @@ OLAPStatus OLAPEngine::_generate_new_header(
_update_header_file_info(version_entity_vec, new_olap_header);
new_olap_header->set_shard(new_shard);
- _update_header_file_info(version_entity_vec, new_olap_header);
-
res = OlapHeaderManager::save(store, tablet->tablet_id(),
tablet->schema_hash(), new_olap_header);
if (res != OLAP_SUCCESS) {
OLAP_LOG_WARNING("fail to save olap header to new db. [res=%d]", res);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
