chenhao7253886 commented on a change in pull request #386: Fix bug that null
value is loaded via mini load operation
URL: https://github.com/apache/incubator-doris/pull/386#discussion_r238597255
##########
File path: be/src/exec/csv_scan_node.cpp
##########
@@ -484,6 +484,11 @@ bool CsvScanNode::check_and_write_text_slot(
<< "type: " << slot->type() << "; "
<< "input_str: [" << std::string(value, value_length) << "].";
return false;
+ } else if (!slot->is_nullable() && is_null(value, value_length)) {
+ (*error_msg) << "value cannot be null. column name: " << column_name
+ << "; type: " << slot->type() << "; input_str: ["
+ << std::string(value, value_length) << "].";
+ return false;
Review comment:
This can merge the process immediately following that set Tuple's null mark.
No need to call is_nullable() and is_null twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
