chaoyli commented on a change in pull request #388: remove batch process code
from push handler (#385)
URL: https://github.com/apache/incubator-doris/pull/388#discussion_r238938499
##########
File path: be/src/olap/olap_snapshot.cpp
##########
@@ -396,7 +396,15 @@ OLAPStatus OLAPEngine::_create_snapshot_files(
for (const VersionEntity& entity : shortest_versions) {
if (entity.version.second == request.version) {
if (entity.version.first != request.version) {
- res = _append_single_delta(request, store);
+ // visible version in fe is 900
+ // A need to clone 900 from B, but B's last version is
901, and 901 is not a visible version
+ // and 901 will be reverted
+ // since 900 is not the last version in B, 900 maybe
compacted with other versions
+ // if A only get 900, then A's last version will be a
comulative delta
+ // many codes in be assumes that the last version is a
single delta
+ // both clone and backup restore depend on this logic
+ // TODO (yiguolei) fix it in the future
+ // res = _append_single_delta(request, store);
Review comment:
annotation is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
