morningman commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r228831444
##########
File path: fe/src/com/baidu/palo/catalog/Catalog.java
##########
@@ -2569,6 +2601,13 @@ public void addPartition(Database db, String tableName,
AddPartitionClause addPa
// here we check partition's properties
singlePartitionDesc.analyze(rangePartitionInfo.getPartitionColumns().size(),
null);
+ if (olapTable.getColocateTable() != null) {
+ short tableReplicationNum =
rangePartitionInfo.idToReplicationNum.entrySet().iterator().next().getValue();
+ if (tableReplicationNum !=
singlePartitionDesc.getReplicationNum()) {
+
ErrorReport.reportDdlException(ErrorCode.ERR_COLOCATE_TABLE_MUST_SAME_REPLICAT_NUM,
partitionName);
Review comment:
ERR_COLOCATE_TABLE_MUST_SAME_REPLICAT_NUM
misspelling REPLICAT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
