imay commented on a change in pull request #1445: Add string function split_part
URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368553
##########
File path: be/src/exprs/string_functions.cpp
##########
@@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(FunctionContext
*context, const LargeInt
return do_money_format(context, ss.str());
}
+static int indexOf(const uint8_t* source, int sourceOffset, int sourceCount,
Review comment:
```suggestion
static int index_of(const uint8_t* source, int sourceOffset, int sourceCount,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
