imay commented on a change in pull request #1443: Persist auth info in LoadJob
URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301377754
##########
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java
##########
@@ -236,6 +254,8 @@ protected void setJobProperties(Map<String, String>
properties) throws DdlExcept
}
}
+ abstract void setAuthorizationInfo() throws MetaNotFoundException;
Review comment:
It's strange that a set function without any input param. I think that this
can be done in class's constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
