yiguolei commented on a change in pull request #1576: Change cumulative
compaction for decoupling storage from compution
URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310463898
##########
File path: be/src/olap/tablet.cpp
##########
@@ -736,6 +749,32 @@ OLAPStatus
Tablet::max_continuous_version_from_begining(Version* version, Versio
return OLAP_SUCCESS;
}
+OLAPStatus Tablet::calcuate_cumulative_point() {
+ ReadLock rdlock(&_meta_lock);
+ std::list<Version> existing_versions;
Review comment:
It is used during init. Does it need meta lock really?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]