On Mon, Dec 08, 2014 at 11:09:13AM +0000, Bruce Richardson wrote:
> On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote:
> > Add defconfig and rte.vars.mk files for Tile architecture.
> >
> > Signed-off-by: Zhigang Lu <zlu at ezchip.com>
> > Signed-off-by: Cyril Chemparathy <cchemparathy at ezchip.com>
> > ---
> > config/defconfig_tile-tilegx-linuxapp-gcc | 78
> > +++++++++++++++++++++++++++++++
> > mk/arch/tile/rte.vars.mk | 59 +++++++++++++++++++++++
> > mk/machine/tilegx/rte.vars.mk | 58 +++++++++++++++++++++++
> > 3 files changed, 195 insertions(+)
> > create mode 100644 config/defconfig_tile-tilegx-linuxapp-gcc
> > create mode 100644 mk/arch/tile/rte.vars.mk
> > create mode 100644 mk/machine/tilegx/rte.vars.mk
> >
>
> I think this should probably be the final patch in the series, rather than the
> first. It's generally best to set up all requirements first before enabling
> things
> in the compile time configuration. Once this patch is added, there is a
> non-functional
> target added for tile architecture. If it's added last, the moment the compile
> time config is added it works correctly.
>
> /Bruce
>
>
Agreed, this should be last. Also, just for clarity, you're posting this very
close to the 1.8 release. I presume your intent is to add this in for the 2.0
release, correct?
Neil