> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, December 11, 2014 5:08 PM > To: dev at dpdk.org > Cc: root > Subject: [dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf > > Since commit fbde27f19ab8f "get default Rx/Tx configuration from dev info", > a default RX/TX configuration can be used for all PMDs. > In case of vmxnet3, the whole structure was zeroed and not filled out. > The PMD does not support multi segments or offload functions, > so txq_flags should have those flags set. > > Signed-off-by: root <root at sie-lab-214-174.ir.intel.com>
Self-NACK. Wrong signed-off. > --- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > index 963a8a5..ef0af16 100644 > --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > @@ -642,6 +642,9 @@ > vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, > struct rte_ > dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM; > dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS > register */ > dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS; > + > + dev_info->default_txconf.txq_flags = > ETH_TXQ_FLAGS_NOMULTSEGS | > + > ETH_TXQ_FLAGS_NOOFFLOADS; > } > > /* return 0 means link status changed, -1 means not changed */ > -- > 1.7.4.1
