Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, December 17, 2014 12:37 AM > To: Ouyang, Changchun > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue > > 2014-12-12 12:15, Ouyang Changchun: > > The following commit break vm2vm hard mode test cases: > > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > > Author: Huawei Xie <huawei.xie at intel.com> > > Date: Thu Nov 13 06:34:07 2014 +0800 > > examples/vhost: use factorized default Rx/Tx configuration > > > > Investigation show that it needs enabling vlan offload since it is > > turn off by default, and Tx need it, especially when vm2vm is in hard mode. > > I missed something here. Where VLAN offload is disabled by default? > Could you point the code, please?
Inside the function ixgbe_dev_info_get() The txq_flags is assigned value of "ETH_TXQ_FLAGS_MULTISEGS|ETH_TXQ_FLAGS_NOOFFLOADS", The ETH_TXQ_FLAGS_NOOFFLOADS contain ETH_TXQ_FLAGS_NOVLANOFFL. so VLAN offload is disabled. Do you think any incorrect in my original description? Thanks and regards, Changchun