Hi Changchun > -----Original Message----- > From: Ouyang, Changchun > Sent: Wednesday, December 24, 2014 11:22 AM > To: Zhang, Helin; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > Hi Helin, > > > -----Original Message----- > > From: Zhang, Helin > > Sent: Wednesday, December 24, 2014 11:08 AM > > To: Ouyang, Changchun; dev at dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > Is header split really supported in ixgbe? I guess not. If not, this > > code changes are not needed at all. > > > > I don't try to modify any logic here, as you know vf rss don't have nothing > to do > with header split. But you modified code for header split. Have you validated it?
> You mean " guess not ", can you 'make sure of it' rather than 'guess' if you > want > to remove those codes? I did not see anywhere can enable ixgbe header split. It is your turn to make sure if your code changes are needed and correct. I don't want to remove any code, just want to know if your code have been validated for header split. > > Thanks > Changchun