Maxime, Thanks for your comment. If we want testpmd to have RSS always enabled out of box (note that rxq=1), then your suggestion makes sense. I?m new to dpdk so I was trying to preserve the current behavior. Now looking back, I guess that?s why we have an explicit disable-rss option. If I don?t hear any resistance by tomorrow, I will submit a new patch. Thanks.
Dan PS. I don?t see port_rss_hash_conf_show in config.c, at not in 1.5.1 branch. Which branch is this in? On Jan 14, 2014, at 9:42 AM, Maxime Leroy <maxime.leroy at 6wind.com> wrote: > Hello, > > Thanks for your patch fixing the regression introduced by my commit > (igb/ixgbe: ETH_MQ_RX_NONE should disable RSS). > > I have one comment about your fix. I don't think there are any reasons > to not enable RSS with only one RX queue in testpmd. > > RSS is mainly used in testpmd to spread traffic on the different rx queues. > But you can use RSS with one rx queue for debbugging purpose. > For example, you can use the rxonly forward engine of the testpmd to display > the RSS hash. (see pkt_burst_receive in app/test-pmd/rxonly.c) > > An other issue about not enabling RSS with 1 queue, when you use the command > show_rss_key in the testpmd, this one will display that the RSS is enabled. > (because rss_hf != 0; see port_rss_hash_conf_show function in > app/test-pmd/config.c) > > Do you agree with my analyze ? > > Thanks. > > -- > Maxime Leroy