Hi, > Subject: [memnic PATCH 1/3] pmd: remove symlink > > No need to have a symbolic link to a common file > when it can be simply included.
Looks fine to me. When I prepared the file with a bit complex file path layout, easy to keep consistency. Because you separated the code from DPDK vSwitch, there is no reason to do that. thanks, Hiroshi > > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com> > --- > pmd/Makefile | 2 +- > pmd/memnic.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > delete mode 120000 pmd/memnic.h > > diff --git a/pmd/Makefile b/pmd/Makefile > index a96e125..7f96af1 100644 > --- a/pmd/Makefile > +++ b/pmd/Makefile > @@ -59,7 +59,7 @@ ifeq '$(RTE_INCLUDE)' '' > endif > $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \ > -I$(RTE_INCLUDE) -include $(RTE_CONFIG) \ > - -o $@ $< > + -I$S/../common -o $@ $< > > install : $(DESTDIR)$(libdir)/$(SOLIB) > install -D -m 644 $S/README.rst $(DESTDIR)$(docdir)/README.rst > diff --git a/pmd/memnic.h b/pmd/memnic.h > deleted file mode 120000 > index 5303ad4..0000000 > --- a/pmd/memnic.h > +++ /dev/null > @@ -1 +0,0 @@ > -../common/memnic.h > \ No newline at end of file > -- > 1.7.10.4