On Sat, Jul 12, 2014 at 12:30:34AM +0200, Thomas Monjalon wrote:
> About the form of the patch, I have 2 comments:
>
> 1) A doc explaining the design, the dependencies and how it can be used would
> be a great help. Could you write it in rst format?
What is rst format? Are there other examples in the repository?
> 2) checkpatch.pl returns these errors:
>
> ERROR:SPACING: space required before the open parenthesis '('
> #468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
> + if(sockfd != -1)
>
> ERROR:SPACING: space required before the open parenthesis '('
> #471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
> + if(sockfd != -1)
>
> ERROR:SPACING: spaces required around that '=' (ctx:VxV)
> #712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
> + ifr.ifr_name[ifnamelen]='\0';
OK. FWIW, at least the first two are slightly changed from what was
copied from the PCAP driver. The other probably was a cut-n-paste
error from another source.
I'll post a V2 shortly...
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
