Hi Helin,
2014-06-20 14:14, Helin Zhang:
> In VF driver, crc stripping hw offload is enabled or not, according
> to the configurations in config file.
>
> Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> Acked-by: Cunming Liang <cunming.liang at intel.com>
> Acked-by: Jing Chen <jing.d.chen at intel.com>
[...]
> static int
> -i40evf_dev_configure(__rte_unused struct rte_eth_dev *dev)
> +i40evf_dev_configure(struct rte_eth_dev *dev)
> {
> + struct rte_eth_conf* conf = &dev->data->dev_conf;
> +
> +#ifdef RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC
> + if (conf->rxmode.hw_strip_crc) {
> + conf->rxmode.hw_strip_crc = 0;
> + PMD_DRV_LOG(INFO, "VF can not enable hw CRC stripping\n");
> + }
> +#else
> + if (!conf->rxmode.hw_strip_crc) {
> + conf->rxmode.hw_strip_crc = 1;
> + PMD_DRV_LOG(INFO, "VF can not disable hw CRC stripping\n");
> +}
> +#endif
> +
> return 0;
> }
Please, I don't understand why CRC stripping must be configured at build time.
I understand VF capability depends of the PF configuration, but we should be
able to configure it at run time.
--
Thomas
